In this paper, ZnS/CdS core/shell nanotubes were successfully synthesized by combining hydrothermal treatment and ion exchange conversion, and the significant influence of CdS content in the shell on photo absorption and photocatalytic activity was also investigated. The core/shell nanotubes structure of CdS deposition on both sides of ZnS nanotube was confirmed by scanning electron microscopy (SEM) and high resolution transmission electron microscopy (HRTEM). The room temperature PL spectra of ZnS/CdS core/shell nano tubes indicated that CdS on the shell can reduce the recombination of photon-generated electron and hole, The photocatalytic activity tests prove that ZnS/CdS nanotubes have much higher photocatalytic hydrogen production activity than ZnS nanotube and CdS nanotube. Under the irradiation of visible light, the highest photocatalytic hydrogen production rate of 110 mu mol h(-1) g(-1) is observed over the ZnS/CdS core/shell nanotubes with CdS/ZnS molar ratio of 1:4, which is about 11.02 and 5.56 times more active than ZnS nanotube and CdS nanotube, respectively. The improved performance of ZnS/CdS samples can be due to the strong photo response in the visible light region and the efficient separation of electron- hole pairs. (C) 2017 Hydrogen Energy Publications LLC. Published by Elsevier Ltd. All rights reserved.