Twenty-four UK coals ranging in rank with 4.6%-37.6% volatile matter were analysed for 46 major and trace elements. The samples were obtained from the UK Coal Bank and are representative of the major UK coal fields. The major element distributions are interpreted in terms of the mineralogical variations-quartz and kaolinite are largely responsible for the Si and Al, carbonates for Ca and Mg and pyrite for Fe. Also exerting an influence in some samples are siderite, At-phosphate minerals and illite. Based on statistical relationships with the major elements, Rb, Cr, Th, Ce, Zr, Y, Ga, La, Ta, Nb and V are thought to be mainly present in the clay minerals, and As, Mo, Sb, Tl, Se and Bi and Pb are probably present in pyrite. Strontium and Ba are concentrated in a restricted number of samples related to the phosphate minerals. Germanium is the only element for which a major organic association can be demonstrated. Elements with an indirect association with the organic matter are Na, Cl, and Br in porefluids and possibly Te. The ash content is controlled mainly by the detrital input and the trace elements related to the ash content are therefore those elements associated with the clay minerals. Variations with rank would appear to be mainly related to the moisture content (porefluids). The trace elements associated with the quartz and clay minerals are thought to be dominantly detrital in origin. The non-detrital elements, essentially those contained in pyrite, an thought to have been incorporated in the depositional environment from waters with enhanced salinities through seawater ingress, hence there are positive relationships between S and trace element concentrations,